filemanager: attributes route and misc CORS changes #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalenic
added
filemanager
|
Reviewing... |
williamputraintan
approved these changes
Aug 26, 2024
compose.yml
Outdated
| @@ -71,6 +71,7 @@ services: | |||
| - DATABASE_URL=postgresql://orcabus:orcabus@db:5432/filemanager | |||
| - RUST_LOG=debug | |||
| - FILEMANAGER_API_CORS_ALLOW_ORIGINS=${FILEMANAGER_API_CORS_ALLOW_ORIGINS:-http://localhost:8400} | |||
There was a problem hiding this comment.
Perhaps this could be http://localhost:3000, as we set the local port for UI to 3000.
|
As a side note when the UI is deployed, we still need to adjust the cors from the s3 bucket side 😅 |
victorskl
approved these changes
Aug 26, 2024
reisingerf
approved these changes
Aug 26, 2024
This would be outside of the OrcaBus stack right, as the bucket configuration is not controlled in this repo? |
|
Yup. Will; please feel free to PR for required/desired CORS setting at bucket TF. |
|
Good to merge? |
…ager-misc # Conflicts: # lib/workload/stateless/stacks/filemanager/filemanager-migrate-lambda/src/main.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #495
Depends on #460
Changes
/api/v1/s3/attributeswhich accepts arbitrary parameters that can be a shortcut to querying by top-level attribute properties.Misc
content-typeandcontent-encodingfrom the client when creating presigned URLs.