Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Update API Gateway Configuration #531

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Feat: Update API Gateway Configuration #531

merged 4 commits into from
Sep 4, 2024

Conversation

williamputraintan
Copy link
Member

  • Group the APIGW microservice config as one props across microservice.
  • Integrate orcaui's cognito to microservice APIGW
  • Update some CORS config on APIGW

williamputraintan
williamputraintan commented Sep 3, 2024
View reviewed changes
lib/workload/stateless/stacks/filemanager/deploy/stack.ts
integration: apiIntegration,
routeKey: HttpRouteKey.with('/{proxy+}', HttpMethod.GET),
});

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmalenic Wanted to confirm from the FM docs, FM only used GET and PATCH method?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a POST route as well on /api/v1/ingest which manually ingests data from an SQS queue. It isn't being used right now, but could you also please add it here?

Copy link
Member Author

@williamputraintan williamputraintan Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated - ccf38b2

@williamputraintan
Copy link
Member Author

williamputraintan commented Sep 3, 2024 •
edited
Loading

Apparently, APIGW JWT Authorizer works best where we define each method instead of ANY. It seems that defining this way allows the OPTIONS to respond without an authorizer header included, whereas ANY require all methods to have an auth header.

Ref: https://stackoverflow.com/questions/60830115/api-gateway-http-api-cors

williamputraintan
williamputraintan commented Sep 3, 2024
View reviewed changes
skel/django-api/deploy/stack.ts
const httpApi = srmApi.httpApi;

const apiIntegration = new HttpLambdaIntegration('ApiIntegration', apiFn);

new HttpRoute(this, 'HttpRoute', {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victorskl @reisingerf On the SRM and WFM only the GET method currently used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read only GET for now.

@williamputraintan williamputraintan self-assigned this Sep 3, 2024
@williamputraintan williamputraintan added the feature New feature label Sep 3, 2024
@williamputraintan williamputraintan merged commit 36bb67b into main Sep 4, 2024
5 checks passed
@williamputraintan williamputraintan deleted the feat/api-gateway-cors branch September 4, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalenic mmalenic mmalenic approved these changes

@reisingerf reisingerf reisingerf approved these changes

@victorskl victorskl victorskl approved these changes

Assignees

@williamputraintan williamputraintan

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williamputraintan @victorskl @reisingerf @mmalenic