Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(filemanager): compile database and migrations #534

Merged
merged 7 commits into from
Sep 6, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Sep 5, 2024

Closes #530

Changes

  • A running postgres database is no longer required to compile filemanager (reducing some compile times and hopefully repetitive compilations too).
    • sqlx queries no longer use macros and instead use runtime functions.
    • sea-orm entities are still generated by filemanager-build, however as a separate step to build.rs. The entities are checked into the codebase, and are assumed to be up to date when running deployment related steps. When developing in the filemanager directory, a database connection is still required to refresh the entities.
  • Filemanager migrations are squashed.

@mmalenic mmalenic self-assigned this Sep 5, 2024
@mmalenic mmalenic added filemanager an issue relating to the filemanager refactor labels Sep 5, 2024
@mmalenic
Copy link
Member Author

mmalenic commented Sep 5, 2024

This PR should also close #532.

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalenic mmalenic merged commit f954ff7 into main Sep 6, 2024
5 checks passed
@mmalenic mmalenic deleted the refactor/fm-compile-database branch September 6, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filemanager an issue relating to the filemanager refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filemanager: remove database requirement to compile code
2 participants