Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lane to bclconvert samplesheet if it doesn't exist #552

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

alexiswl
Copy link
Member

If there is no lane attribute in the samplesheet bclconvert_data section, collect the runinfo xml and duplicate every row in the samplesheet for every lane in the instrument run

@alexiswl alexiswl self-assigned this Sep 15, 2024
@victorskl victorskl added bug Something isn't working fix labels Sep 15, 2024
Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor unit test case to attend.

@alexiswl
Copy link
Member Author

Ah looks like more-itertools isn't a builtin, will add to the requirements tomorrow

@alexiswl alexiswl merged commit d31478b into main Sep 16, 2024
6 checks passed
@alexiswl alexiswl deleted the bugfix/add-lane-to-samplesheet branch September 16, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cttso glue fails when lane attribute is not found in the bclconvert settings
2 participants