Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for 0.2.1 #573

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Bug fixes for 0.2.1 #573

merged 1 commit into from
Sep 24, 2024

Conversation

alexiswl
Copy link
Member

@alexiswl alexiswl commented Sep 23, 2024

Handle project copy batch:

Fix cttsov2 outputs json:

Roll back library_set init

  • Was put in to prevent sfn failure when a sample type was not present on a run but now fails due to dynamodb not supporting empty sets, will find a better solution soon Library String Set cannot be empty #570

Handle project copy batch:
  * After 'successful' copy, check file sizes are the same between source and destination  #572

Fix cttsov2 outputs json:
  * Error when collecting error message, just a typo #571

Roll back library_set init
  * Was put in to prevent sfn failure when a sample type was not present on a run but now fails due to dynamodb not supporting empty sets, will find a better solution soon  # 570
@alexiswl
Copy link
Member Author

Deploying to dev atm, will kick off one cttso sample first to ensure that 571 and 572 fixes are working properly.

@alexiswl
Copy link
Member Author

@victorskl this one is good to go

@victorskl
Copy link
Member

Sure, will work on patching to prod.

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorskl
Copy link
Member

Merging.. I will cherry pick them.

@victorskl victorskl merged commit 29a9949 into main Sep 24, 2024
6 checks passed
@victorskl victorskl deleted the prod-patch/0-2-1 branch September 24, 2024 00:22
victorskl added a commit that referenced this pull request Sep 24, 2024
victorskl added a commit that referenced this pull request Sep 24, 2024
victorskl added a commit that referenced this pull request Sep 24, 2024
Merge pull request #573 from umccr/prod-patch/0-2-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants