Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init for MetadataManager #67

Merged
merged 21 commits into from
Nov 29, 2023
Merged

Init for MetadataManager #67

merged 21 commits into from
Nov 29, 2023

Conversation

williamputraintan
Copy link
Member

@williamputraintan williamputraintan commented Nov 29, 2023

Init for Metadata Manager

Copy link

gitguardian bot commented Nov 29, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
8459008 Generic Database Assignment d69e37e lib/workload/stateless/metadata_manager/src/deploy/lib/metadataManagerStack.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@williamputraintan williamputraintan merged commit 492c4c4 into main Nov 29, 2023
2 checks passed
@williamputraintan williamputraintan deleted the feat/metadata-manager branch November 29, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant