Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitpod #80

Merged
merged 9 commits into from
Jan 19, 2024
Merged

Gitpod #80

merged 9 commits into from
Jan 19, 2024

Conversation

andrewpatto
Copy link
Member

Added the files (WIP) for gitpod
Experiement starting to split the docker compose into separate units

docker-compose.yml Outdated Show resolved Hide resolved
@andrewpatto
Copy link
Member Author

I don't know why the yarn lock file changed - I just did a yarn install.. but anyhow

@victorskl
Copy link
Member

Having a look now

Copy link
Member

@victorskl victorskl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, Patto. I will try myself GitPod later. Just one minor comment to attend. Otherwise good to go.!

docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
.github/workflows/prbuild.yml Show resolved Hide resolved
@victorskl
Copy link
Member

@andrewpatto FYI, I am going to merge this for now. About to rearrange setup a bit. So, will include considering this PR changes too.

@victorskl victorskl merged commit 2ae10d2 into main Jan 19, 2024
2 checks passed
@victorskl victorskl deleted the feature/gitpod-play branch January 19, 2024 05:16
@andrewpatto
Copy link
Member Author

Happy for this merge - actually now thinking if we do this kind of thing we should do it with devcontainers (same as gitpod - but more open standard)

Also that lets us use Github native codespaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants