Small suggestions after Add multi-instance player support in commit 80862c1

[tellezhector]

Small suggestions after commit 80862c1

• If the player is disconnected, let the user know (i.e. print a message that says '(no player)').
• Propagate KeyInterrupt exceptions properly (important for launcher's to properly handle interruptions and redirect interruptions; i.e. if the launcher is interrupted, the launcher can in turn interrupt the sub-process).
• MPRISBlocket._instances can be a set instead of a dictionary. Dictionaries where values are always True can always be translated to sets (and sets also have O(1) time look-ups).
• bus_name_has_owner(bus_name=None) was always equivalent to bus_name_has_owner(bus_name=self._bus_name), removed the redudancy by removing the default value and always passing an explicit value
• moved null check guard within stop_stdin_read_loop, reducing cyclomatic complexity of MPRISBlocket.run

[un-def]

The one thing that seemed odd is that when the current player is disconnected, the blocket goes blank, a little message could be nice to let the user know what's going on.

This is exactly the behavior I expect. I have multiple instances of the blocklet for multiple players, and it's a feature, not quirk, that unused blocklets “collapse”.

If the player is disconnected, let the user know (i.e. print a message that says '(no player)').

I've made this configurable, add -n (no-player) to the command-line arguments or "placeholder": "(no player)" to the JSON config to get the same result. The default is an empty string, that is, it keeps the previous behavior.

Propagate KeyInterrupt exceptions properly

I've removed except KeyboardInterrupt completely as redundant.

MPRISBlocket._instances can be a set instead of a dictionary

A dict is used as an ordered set (insertion-order). When a player disappears, we pick the latest one as a new player. With regular set, there is no way to prioritize one instance over the other (except lexicographically, which makes little sense).

bus_name_has_owner(bus_name=None) was always equivalent to bus_name_has_owner(bus_name=self._bus_name), removed the redudancy by removing the default value and always passing an explicit value

moved null check guard within stop_stdin_read_loop, reducing cyclomatic complexity of MPRISBlocket.run

I've applied these changes. Merged to master as a new PR: #15

Thanks for your contributions!

[un-def]

Closed in favor of #15