Changes from PR #14 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If the player is disconnected, let the user know (i.e. print a message that says `'(no player)'`). * Propagate KeyInterrupt exceptions properly (important for launcher's to properly handle interruptions and redirect interruptions; i.e. if the launcher is interrupted, the launcher can in turn interrupt the sub-process). * `MPRISBlocket._instances` can be a `set` instead of a dictionary. Dictionaries where values are always True can always be translated to sets (and sets also have O(1) time look-ups). * `bus_name_has_owner(bus_name=None)` was always equivalent to `bus_name_has_owner(bus_name=self._bus_name)`, removed the redudancy by removing the default value and always passing an explicit value * moved null check guard within stop_stdin_read_loop, reducing cyclomatic complexity of MPRISBlocket.run
tellezhector
reviewed
Sep 8, 2024
i3blocks_mpris.py
Outdated
| self._instances = set() | ||
| # a dict used as an ordered set, keys — well-known names with unique | ||
| # instance suffixes, values — True | ||
| self._instances = {} |
There was a problem hiding this comment.
Ah! sorry about this part of the change, my understanding was that dictonaries had no guaranteed order! but that was an old thing (prev to 3.7).
https://docs.python.org/3.7/library/stdtypes.html#dict
At the moment of writting, at the very bottom of this section there is this note:
Changed in version 3.7: Dictionary order is guaranteed to be insertion order. This behavior was an implementation detail of CPython from 3.6.
tellezhector
reviewed
Sep 8, 2024
| @@ -240,8 +240,6 @@ def run(self, *, loop=None, read_stdin=True, nowait=False): | |||
| self.start_stdin_read_loop() | |||
| try: | |||
| self._loop.run() | |||
| except KeyboardInterrupt as e: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #14