Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL Alignment Data Import as Target Language Project from USFM 3 File #3186

Closed
klappy opened this issue Nov 14, 2017 · 8 comments · Fixed by #3895
Closed

GL Alignment Data Import as Target Language Project from USFM 3 File #3186

klappy opened this issue Nov 14, 2017 · 8 comments · Fixed by #3895
Assignees
Milestone

Comments

@klappy
Copy link
Contributor

klappy commented Nov 14, 2017

  • GL Alignment Data Import as Target Language Project from USFM 3 File
    • USFM.js: Improved USFM 3 to Verse Objects
    • tC Helpers: Split Verse Objects to Target Verse String and Alignment Data

Alignment data for target language project import will be handled in: #3559

@klappy klappy closed this as completed Nov 14, 2017
@klappy klappy reopened this Nov 14, 2017
@benjore benjore added this to the tC Sprint #46 milestone Dec 5, 2017
@klappy
Copy link
Contributor Author

klappy commented Dec 5, 2017

Tasks

[8] USFM3 Import: Tests for Split Verse Objects to Target Verse and Alignment Data
[8] USFM3 Import: Helper to Split Verse Objects to Target Verse and Alignment Data
[8] USFM3 Import: Changes to USFM.js library as needed, release and update

@klappy
Copy link
Contributor Author

klappy commented Jan 31, 2018

New Tasks

[4] Fix Occurrence(s) bug
[6] Use VerseObjects instead of WordObjects
[12] Write Migrations for WordAlignment Data from wordObjects to verseObjects
[6] Update USFM import to support VerseObjects from USFM.js
[6] Update/Fix broken USFM tests

klappy added a commit that referenced this issue Feb 2, 2018
…lignmentFromVerseObjects

Feature #3186/Fix broken unit tests
klappy added a commit that referenced this issue Feb 5, 2018
…UseVerseObjects

Feature mcleanb #3186/use verse objects
klappy added a commit that referenced this issue Feb 7, 2018
…MigrateAlignmentData

Feature #3186/migrate alignment data
@klappy klappy added the QA/Hold label Feb 7, 2018
@cckozie
Copy link

cckozie commented Feb 8, 2018

Need USFM3 file to test.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Feb 8, 2018

Known issues:

#3757 - Unmerging Greek words changes word order
#3758 - USFM import does not preserve all header info

@cckozie
Copy link

cckozie commented Feb 12, 2018

I'm not sure that it's the import that's broken, but the exported file looks like it has all of the data and no alignments show up in the imported project. (The exported project was 100% aligned)

@cckozie cckozie added QA/Fail and removed QA/Hold labels Feb 12, 2018
@klappy
Copy link
Contributor Author

klappy commented Feb 12, 2018

@cckozie: The current use case is to import via the tC_resources for the GL languages. We discussed in a standup last week with @benjore and @jag3773 to not fix the use case of importing the exported file in the application just yet. That will be handled in a separate story. We brought that up so that we could pass these stories but this particular one does pose a problem for QA testing.

@benjore and @jag3773 can you weigh in on how to proceed?

@benjore
Copy link

benjore commented Feb 13, 2018

I need to be able to import a USFM3 file and use it as a work-in-progress project in the word alignment tool.

@benjore benjore modified the milestones: tC Sprint #50, tC Sprint #51 Feb 13, 2018
@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Feb 14, 2018

Tasks:

  • [4] extract and save alignments on USFM import (generateTargetLanguageBibleFromUsfm)
  • [4] update unit tests
  • [4] PR reviews

mannycolon added a commit that referenced this issue Feb 22, 2018
…importAlignmentDataWithUSFM.3

Feature #3186/import alignment data with USFM import, and fix alignment export to USFM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants