Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USFM import does not preserve all header info #3758

Closed
PhotoNomad0 opened this issue Feb 8, 2018 · 7 comments
Closed

USFM import does not preserve all header info #3758

PhotoNomad0 opened this issue Feb 8, 2018 · 7 comments
Assignees
@PhotoNomad0
Labels
Epic QA/Pass
Milestone
tC Sprint #51

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Feb 8, 2018 •
edited
Loading

USFM import does not preserve all header info. Some known items not preserved:

\ide UTF-8
\toc1 The Book of Psalms
\toc2 Psalms
\toc3 Psa
\mt The Book of Psalms
\ms Book One
This was referenced Feb 8, 2018
Closed
Closed
@benjore benjore added this to the tC Sprint #51 milestone Feb 13, 2018
@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Feb 14, 2018 •
edited
Loading

Tasks:

  • [2] save import header info
  • [4] export header info
  • [4] update unit tests
  • [6] PR Review

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Feb 15, 2018 •
edited
Loading

fixing ID tag format to be:

TIT EN_ULB Kiswahili_sw_ltr Wed Jul 26 2017 22:14:55 GMT-0700 (PDT) tc

klappy added a commit that referenced this issue Feb 17, 2018
@klappy
Merge pull request #3797 from unfoldingWord-dev/BugFix-mcleanb-3758/P…
46a3fd4 
…reserveHeaderInfoOnUsfmImport

Bugfix #3758/preserve header info on USFM import
@cckozie
Copy link

cckozie commented Feb 20, 2018 •
edited
Loading

php_usfm.usfm.zip
I'm not sure that this is what caused the issue, but this usfm projects now open to a blank checking screen in tW with no console errors. It does open properly in word alignment.

es-419_luk_text_ulb.usfm.zip
This project also opens to a blank checking screen in tW. It does open in word alignment but it has verse markers displayed in the word list and scripture pane when there are missing verses.
image

This may be the same problem causing footnotes to show up in the word list that I wrote up in #3209

@PhotoNomad0
Copy link
Contributor Author

Can you check this again. I think this has been fixed. Not seeing this problem in latest build - tested on windows.

@cckozie
Copy link

cckozie commented Feb 26, 2018

Both problems still exist in 0.8.1-alpha.18-f5cb8b8 on both Mac and Windows.

@cckozie
Copy link

cckozie commented Feb 26, 2018 •
edited
Loading

The first issue is apparently due to missing tW data for non-Titus projects. I will ignore it in that case, and issue #3911 will address the problem of alerting the user as to why the project cannot be checked in tW.
The second issue was moved to #3913

@cckozie cckozie removed the QA/Fail label Feb 26, 2018
@cckozie
Copy link

cckozie commented Feb 26, 2018

This was tested only using USFM2 data. USFM3 files do not yet contain all of the non-displayed elements.

@cckozie cckozie added QA/Pass and removed QA/Retest labels Feb 26, 2018
@benjore benjore closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhotoNomad0 PhotoNomad0

Labels
Epic QA/Pass
Projects
None yet
Milestone
tC Sprint #51
Development

No branches or pull requests
3 participants
@cckozie @benjore @PhotoNomad0