Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TN links with IDs and more varieties of Bible links #140

Merged
merged 6 commits into from
Feb 1, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Jan 26, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft January 26, 2021 09:04
@RobH123 RobH123 linked an issue Jan 27, 2021 that may be closed by this pull request
@RobH123 RobH123 marked this pull request as ready for review February 1, 2021 09:02
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #140 (9494287) into master (d369a41) will decrease coverage by 1.04%.
The diff coverage is 29.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   46.50%   45.46%   -1.05%     
==========================================
  Files          22       22              
  Lines        2901     3073     +172     
  Branches      948      991      +43     
==========================================
+ Hits         1349     1397      +48     
- Misses        970     1060      +90     
- Partials      582      616      +34     
Impacted Files Coverage Δ
src/core/annotation-row-check.js 2.55% <0.00%> (ø)
src/core/disabled-notices.js 72.22% <ø> (ø)
src/core/usfm-text-check.js 56.34% <0.00%> (ø)
src/core/tn-links-check.js 42.23% <29.76%> (-11.27%) ⬇️
src/core/tn-table-row-check.js 71.91% <100.00%> (ø)
src/core/utilities.js 39.39% <100.00%> (+9.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d369a41...9494287. Read the comment docs.

@RobH123
Copy link
Contributor Author

RobH123 commented Feb 1, 2021

Does better checking of TN links, especially Bible links. Also, some improvements to wording of a couple of error messages.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 21 of 22 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ancientTexts-net)

@mandolyte mandolyte merged commit 79c9680 into master Feb 1, 2021
@mandolyte mandolyte deleted the RJHimprovements branch February 1, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants