Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cumulative improvements #71

Merged
merged 20 commits into from
Dec 31, 2020
Merged

More cumulative improvements #71

merged 20 commits into from
Dec 31, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Dec 9, 2020

Closing #68


This change is Reviewable

@RobH123 RobH123 marked this pull request as draft December 9, 2020 20:09
@RobH123 RobH123 linked an issue Dec 9, 2020 that may be closed by this pull request
@RobH123 RobH123 linked an issue Dec 13, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #71 (48b7fe4) into master (b62b64b) will increase coverage by 1.09%.
The diff coverage is 51.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   45.95%   47.05%   +1.09%     
==========================================
  Files          21       22       +1     
  Lines        2681     2782     +101     
  Branches      848      892      +44     
==========================================
+ Hits         1232     1309      +77     
- Misses        915      925      +10     
- Partials      534      548      +14     
Impacted Files Coverage Δ
src/core/annotation-row-check.js 2.55% <0.00%> (ø)
src/core/disabled-notices.js 100.00% <ø> (ø)
src/core/field-link-check.js 0.00% <0.00%> (ø)
src/core/getApi.js 23.21% <0.00%> (+12.49%) ⬆️
src/core/usfm-js-check.js 11.76% <0.00%> (ø)
src/core/utilities.js 14.28% <ø> (ø)
src/core/manifest-text-check.js 4.81% <4.34%> (-0.52%) ⬇️
src/core/yaml-text-check.js 1.40% <7.69%> (-0.09%) ⬇️
src/core/annotation-table-check.js 2.27% <12.50%> (-0.04%) ⬇️
src/core/usfm-text-check.js 57.01% <32.72%> (-2.30%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62b64b...48b7fe4. Read the comment docs.

@RobH123 RobH123 linked an issue Dec 16, 2020 that may be closed by this pull request
@RobH123 RobH123 linked an issue Dec 16, 2020 that may be closed by this pull request
@RobH123 RobH123 linked an issue Dec 23, 2020 that may be closed by this pull request
@RobH123 RobH123 marked this pull request as ready for review December 23, 2020 08:24
@RobH123 RobH123 requested a review from mandolyte December 23, 2020 08:26
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 46 files at r1, 66 of 66 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ancientTexts-net)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants