Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-14581 Change plural rule format from 2e6 to 2c6 #1100

Conversation

macchiati
Copy link
Member

Checklist

@macchiati macchiati requested a review from pedberg-icu March 9, 2021 19:50
@macchiati
Copy link
Member Author

Made the file change, but didn't run the tests locally, so will find out soon. It might need the ICU change from Elango merged before it will run.

@macchiati
Copy link
Member Author

macchiati commented Mar 9, 2021

Yup, fails in com.ibm.icu.text.PluralRules$FixedDecimal.parseDecimalSampleRangeNumString(PluralRules.java:862), so we need to get the change from Elango merged before we can really test.

@macchiati macchiati requested review from echeran and sffc March 9, 2021 19:54
@macchiati
Copy link
Member Author

Hmmm. I guess this pulls in the right ICU version, so we are ok.

Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peter gave the go-ahead and merged the ICU change dependency in ICU PR 1624, and this rule change LGTM.

@pedberg-icu
Copy link
Contributor

Peter gave the go-ahead and merged the ICU change dependency in ICU PR 1624, and this rule change LGTM.

BUT: I have not copied the ICU with that change back to CLDR yet. I am working on a PR for that but it has some test failures.

@pedberg-icu
Copy link
Contributor

Peter gave the go-ahead and merged the ICU change dependency in ICU PR 1624, and this rule change LGTM.

BUT: I have not copied the ICU with that change back to CLDR yet. I am working on a PR for that but it has some test failures.

OK, PR-1102 updates the ICU4J libraries in CLDR to include Elango's fix ICU-PR-1624 to make compact notation 'c' behave like 'e' in FixedDecimal.

@pedberg-icu pedberg-icu merged commit 02a697d into unicode-org:maint/maint-39 Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants