-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-21519 Make compact notation 'c' behave like 'e' in FixedDecimal #1624
Conversation
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rslgtm
I know we discussed need this for CLDR 39 to include this data.
The changes look plausible. I would prefer if someone who has been in on these discussion could review the changes, but I don't want you (& CLDR) to be blocked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works; it probably does a bit more work than it needs to, since I think it could have just mapped 'c' to 'e' on input, and 'e' to 'c' on output, rather than supporting both. But that can always be adjusted later, since this is not public api.
cc @sffc
OK to merge this so I can pick up an ICU with this fix for CLDR? |
The appveyor failure is a segfault while compiling translit.cpp, certainly nothing to do with this change or (likely) even ICU. I am going to go ahead and merge this. |
Checklist