-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix negative numbers across icu_calendar #2703
Comments
I ended up fixing half of this whilst attempting to fix the coptic issue |
Pretty sure that @sffc where did you get these fixed values from? |
Oh, though it might be a zero-indexed vs 1-indexed difference, argh |
Nope, we're both 1-indexed. |
I calculated the fixed values manually.
|
Ah, there's your problem, fixed day 0 is not Jan 1 1 AD (that's fixed 1), it is Dec 31 1 BC I fixed it in the tests |
#3477 handles Julian |
@atcupps should this issue be closed now, or are there still bits left to be handled? |
Here are the calendars that have included negative date testing:
So there's still quite a few more to be done. |
There are still bugs involving negative dates. See #4894 A good next step would be to scrub the crate of any remaining |
Poking around, I keep finding places in icu_calendar where we do the wrong thing with negative numbers. We need to fix this, since one value proposition of ICU4X's calendar crate is that we generate correct results across the range required by Temporal.
I made a branch, iso-negative, with some test cases that are currently failing.
Actions on this ticket:
div_rem_euclid
helper function (Add div_rem_euclid and use it in icu_calendar #2704)Related: #2151
CC @pt2121 @Manishearth @pandusonu2
The text was updated successfully, but these errors were encountered: