Fix math in calendar #2714
Merged
Fix math in calendar #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2254
Progress on #2703 (but doesn't add many more tests)
I didn't touch week_of since it's not one of the Reingold functions. Someone should figure out what the correct math is to be used there.
I added a
quotient()function for readability since we divide a LOT more often than taking modulus. I'm importing it directly since it's a local helper function;helpers::quotient()is also common Rust style but it's more common when it's from a different crate; and also it's used enough that the verbosity makes it harder to read.