Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement year-week calculations for formatting #488

Closed
4 tasks
sffc opened this issue Feb 9, 2021 · 2 comments · Fixed by #1468
Closed
4 tasks

Implement year-week calculations for formatting #488

sffc opened this issue Feb 9, 2021 · 2 comments · Fixed by #1468
Assignees
@sapriyag
Labels
A-scope Area: Project scope, feature coverage C-datetime Component: datetime, calendars, time zones good first issue Good for newcomers help wanted Issue needs an assignee T-enhancement Type: Nice-to-have but not required

Comments

@sffc
Copy link
Member

sffc commented Feb 9, 2021 •
edited
Loading

#445 introduced a placeholder structure for year-week calculations (week numbering within a year). This logic is required for full UTS 35 compliance. This issue is to track implementation of these calculations.

Suggested task list:

  • Review UTS 35 for information on week calculations (week of month and week of year)
  • Implement week calculations
  • Add week formats as a new key in the datetime data provider
  • Implement the formatting glue code to format the calculated week of month and week of year
@sffc sffc added this to the ICU4X 0.2 milestone Feb 12, 2021
@sffc sffc added A-scope Area: Project scope, feature coverage C-datetime Component: datetime, calendars, time zones T-core Type: Required functionality labels Feb 12, 2021
This was referenced Feb 23, 2021
Merged
Closed
@gregtatum
Copy link
Member

As a follow-up to #480, this will need to handle adding the plural rules to skeletons. At the time of this writing, this would mean turning the second entry of the SkeletonTupleV1 from a single pattern, to an enum of either a pattern, or a TupleVecMap of multiple patterns keyed by the plural form.

@sffc sffc changed the title Implement year-week calculations Implement year-week calculations for formatting Feb 25, 2021
@sffc sffc unassigned dminor Feb 25, 2021
@sffc sffc added backlog help wanted Issue needs an assignee labels Feb 25, 2021
@sffc sffc removed this from the ICU4X 0.2 milestone Feb 25, 2021
@sffc sffc added T-enhancement Type: Nice-to-have but not required and removed T-core Type: Required functionality labels Feb 25, 2021
@sffc sffc added the good first issue Good for newcomers label Jun 10, 2021
@mildgravitas mildgravitas mentioned this issue Jul 28, 2021
Merged
Manishearth pushed a commit that referenced this issue Sep 17, 2021
@mildgravitas
Misc cleanup done for #488 (#1059)
5b1bf88 
* Only compute DateTimeFormatsV1 once when building DatePatternsV1.

* Remove unnecessary get_mut() in parse_placeholders.

* Cleanup redundant test fixture: combine-datetime was forked from date-time 5 months ago but the test still referred to the old file.

* Add a basic skeleton parsing test.

* Update test_components_combine_datetime's comment to the correct path.
@Manishearth
Copy link
Member

(@sapriyag is tracking 20%er work, adding her as an assignee. Unfortunately GH still doesn't let us assign non-org members to issues)

@mildgravitas mildgravitas mentioned this issue Oct 25, 2021
Merged
@mildgravitas mildgravitas mentioned this issue Dec 7, 2021
Merged
@mildgravitas mildgravitas mentioned this issue Mar 16, 2022
Merged
@sffc sffc mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sapriyag sapriyag

Labels
A-scope Area: Project scope, feature coverage C-datetime Component: datetime, calendars, time zones good first issue Good for newcomers help wanted Issue needs an assignee T-enhancement Type: Nice-to-have but not required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for week-of-month. mildgravitas/icu4x
5 participants
@dminor @sffc @gregtatum @Manishearth @sapriyag