-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full audit of datetime renames #5837
Comments
For 2.0 Final I would like every function involving fieldsets to have docs pointing to the fieldset module. Plus every trait like AllAnyCalendarFormattingDataMarkers should explain what its common bounds mean i nrelation to fieldsets, and what to do when the trait isn't implemented. |
(I'm in favor of all bullet points here. Replacing convert_and_format seems fine, we only have it because that was the initial behavior of the module and we wanted to keep it) |
Did you want to weigh in on what this trait should be called? I had recorded a comment that someone didn't like the name but didn't have an alternative. I'm personally still happy with the name. |
No strong opinions, fine with the name. |
I'd kinda like to move it to |
I'd say the same one? One thing to note is that |
For 2.0 Beta:
NeoSkeletonLength
should beLength
IsAnyCalendarKind
format_iso
function onDateTimeFormatter
, possibly replacingconvert_and_format
strict_format
should maybe beformat_same_calendar
FormattedNeoDateTime
should beFormattedDateTime
DateTimePatternFormatter
should have a single genericformat
functionDateTimePatternFormatter
and friends should useFSet
instead ofR
DateTimeNames::with_pattern
should betry_with_pattern
andwith_pattern_unchecked
(Consider exact policy around DateTimeError in datetime formatting #4336 (comment))For 2.0 Final:
The text was updated successfully, but these errors were encountered: