Rename datetime format functions and traits #5847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested review from
Manishearth,
zbraniecki and
a team
as code owners
sffc
requested review from
markusicu
and removed request for
a team and
zbraniecki
markusicu
reviewed
Nov 20, 2024
components/datetime/src/neo.rs
Outdated
| @@ -563,7 +563,7 @@ where | |||
| datetime: &I, | |||
| ) -> Result<FormattedDateTime, crate::MismatchedCalendarError> | |||
| where | |||
| I: ?Sized + IsInCalendar + AllInputMarkers<FSet>, | |||
| I: ?Sized + InCalendar + AllInputMarkers<FSet>, | |||
There was a problem hiding this comment.
optional: how about InSameCalendar to (a) make it more meaningful and (b) make it more parallel with InFixedCalendar?
There was a problem hiding this comment.
Done
Justification: the fully qualified names have good parallelism
DateTimeFormatter::format_same_calendar=>InSameCalendarFixedCalendarDateTimeFormatter::format=>InFixedCalendar
Also, "InCalendar" is too short and could mean something else in the future.
Manishearth
previously approved these changes
Nov 21, 2024
markusicu
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5837