main,refactor: move field null string literals to header (#3740)

universal-ctags · May 31, 2023 · 100a7c2 · 100a7c2
1 parent 7731536
commit 100a7c2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/main/field.c b/main/field.c
@@ -34,9 +34,6 @@
 #include "optscript.h"
 #include "script_p.h"
 
-#define FIELD_NULL_LETTER_CHAR '-'
-#define FIELD_NULL_LETTER_STRING "-"
-
 typedef struct sFieldObject {
 	fieldDefinition *def;
 	vString     *buffer;

diff --git a/main/field_p.h b/main/field_p.h
@@ -24,6 +24,9 @@
 *   DATA DECLARATIONS
 */
 
+#define FIELD_NULL_LETTER_CHAR '-'
+#define FIELD_NULL_LETTER_STRING "-"
+
 
 /*
 *   FUNCTION PROTOTYPES

diff --git a/main/fmt.c b/main/fmt.c
@@ -87,8 +87,7 @@ static int printTagField (fmtSpec* fspec, MIO* fp, const tagEntryInfo * tag)
 				str = renderField (f->ftype, tag, findex);
 				if ((dt & FIELDTYPE_BOOL) && str[0] == '\0')
 				{
-					/* TODO: FIELD_NULL_LETTER_STRING */
-					str = "-";
+					str = FIELD_NULL_LETTER_STRING;
 				}
 			}
 			else if (dt & FIELDTYPE_BOOL)