-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main,refactor: move field null string literals to header. #3740
main,refactor: move field null string literals to header. #3740
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3740 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 226 226
Lines 55039 55050 +11
=======================================
+ Hits 45680 45691 +11
Misses 9359 9359
☔ View full report in Codecov by Sentry. |
Thank you. you've been active. So I would like to write some rules I introduced during you were absent. Your change is not about a specific parser. In that case, could you add "main" to the prefix of the commit header? It implies the change has an impact on the whole of the ctags. If the change is just for code transformation, and if not intended to change the command behavior, use "refactor" (as you already did). You can combine some of the with a comma character. So the header of your commit log should be: If your change is about a parser, use the name of parser as the prefix. See also https://docs.ctags.io/en/latest/contributions.html#committing-and-submitting-a-pull-request |
main/field.h
Outdated
@@ -79,6 +79,9 @@ typedef enum eFieldDataType { | |||
FIELDTYPE_END_MARKER = 1 << 3, | |||
} fieldDataType; | |||
|
|||
#define FIELD_NULL_LETTER_CHAR '-' | |||
#define FIELD_NULL_LETTER_STRING "-" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
field.h is visible to parsers.
fmt.c is a part of the main
part. So let's put the definition to field_p.h.
The _p.h files are private to the main
part.
Let's squash the two commits into one and update the commit log. |
072635d
to
5b4b691
Compare
I always squash merges to master (see, for example, #3739), but here you go. |
Thank you. |
No description provided.