Comments inline with properties breaks css.c parser

[wesbaker]

When there's a comment inline with a property nothing after that selector and property is parsed into tags. For example, try this:

border: 1px solid #b7c7d2; /* won't work with rounded corners, but looks best for non js */

Any ideas on how to fix it?

Thanks,
Wes

[fishman]

sorry i didn't actually see this error before is this still relevant?

[blueyed]

@wesbaker
Can you provide more information, e.g. a sample CSS file, please?
Only in case this is still an issue, of course.

[wesbaker]

I'm no longer using ctags, so I'm not sure if it's an issue anymore.

[masatake]

Single quote in a comment triggers this bug.

foo.css
a {x: 0; /'/}
b {y: 0;}

With this input ctags generates:

a /tmp/foo.css /^a {x: 0; /'/}$/;" s

Only a is tagged.

bar.css, no single quote in the comment:

a {x: 0; /**/}
b {y: 0;}

ctags generates good tags for this input:

a /tmp/foo.css /^a {x: 0; /**/}$/;" s
b /tmp/foo.css /^b {y: 0;}$/;" s

Both a and b are tagged.

A pull request is welcome :-P
Happy hakcing!

[masatake]

I found the parser doesn't handle nested state like a { /**/ }, a comment in a definition.
Managing in-comment state and other states or state stack may be needed.
Amount of work is needed.

[masatake]

I add this as a test case named css-singlequote-in-comment-issue2.b.
So we can debug any time you want.

[masatake]

https://github.com/geany/geany/blob/master/tagmanager/ctags/nestlevel.h may be useful to deal with nested state.

[ffes]

@b4n Can this be closed after the changes of yesterday?

[b4n]

Fixed in dd86469