-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D: parse user-defined attributes #3701
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3701 +/- ##
=======================================
Coverage 82.82% 82.83%
=======================================
Files 226 226
Lines 54752 54754 +2
=======================================
+ Hits 45351 45353 +2
Misses 9401 9401
☔ View full report in Codecov by Sentry. |
A minor request; could you change the commit header to "D: parse user-defined attributes"? |
!_TAG_PROGRAM_AUTHOR Universal Ctags Team // | ||
!_TAG_PROGRAM_NAME Universal Ctags /Derived from Exuberant Ctags/ | ||
!_TAG_PROGRAM_URL https://ctags.io/ /official site/ | ||
!_TAG_PROGRAM_VERSION 6.0.0 /4a101fd4/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove all '!_' tags from the expected.tags.
@masatake Thanks, I've done that except the commits are in opposite order. I hope that's OK (wasn't sure how to do it the other way with git). |
Thank you for updating.
O.k. I will take over this...however, I recommend you to learn 'git rebase -i' and 'git push --force'. |
Quoted from the pull request (universal-ctags#3701): UDAs can precede a declaration or come after a function parameter list. https://dlang.org/spec/attribute.html#uda @mastake edited the commit log.
Hi,
I'm working on porting the remaining Geany D parser changes to ctags.
UDAs can precede a declaration or come after a function parameter list.
https://dlang.org/spec/attribute.html#uda
!_TAG_
should be there. Please let me know if there's a switch I should be using.