Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tcl parser - requiring 'package require Itcl' #3139

Closed
masatake opened this issue Aug 28, 2021 · 0 comments · Fixed by #3140
Closed

Tcl parser - requiring 'package require Itcl' #3139

masatake opened this issue Aug 28, 2021 · 0 comments · Fixed by #3140

Comments

@masatake
Copy link
Member

Tried using the new tags package, but it's not finding nearly as much in my Tcl files.
Looking into the unit tests, and the comments therein, it appears that the new parser(s) for Itcl do not activate unless the file contains 'package require Itcl'.

How do I force the parser for Itcl (and TclOO) to always be active when parsing a Tcl file?

Our code base uses Itcl in 90% of Tcl files, but due to the flow, doesn't have 'package require Itcl' in but a small handful.

Originally posted by @bigfaceworm in #3136
masatake added a commit to masatake/ctags that referenced this issue Aug 28, 2021
@masatake
ITcl: don't require 'package require Itcl'
c452753 
Close universal-ctags#3136.
Close universal-ctags#3139.

The original code requires 'package require Itcl' to run Itcl
subparser from Tcl parser. However, `itcl::` can be used in
a script having no 'package require Itcl' statement.
Suggested by @bigfaceworm.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake mentioned this issue Aug 28, 2021
Merged
masatake added a commit to masatake/ctags that referenced this issue Aug 28, 2021
@masatake
ITcl: don't require 'package require Itcl'
1c3778f 
Close universal-ctags#3136.
Close universal-ctags#3139.

The original code requires 'package require Itcl' to run Itcl
subparser from Tcl parser. However, `itcl::` can be used in
a script having no 'package require Itcl' statement.
Suggested by @bigfaceworm.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ITcl: don't require 'package require Itcl' masatake/ctags
1 participant
@masatake