ITcl: don't require 'package require Itcl' #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3140 +/- ##
==========================================
- Coverage 84.90% 84.90% -0.01%
==========================================
Files 200 200
Lines 47840 47824 -16
==========================================
- Hits 40620 40604 -16
Misses 7220 7220
Continue to review full report at Codecov.
|
Close universal-ctags#3136. Close universal-ctags#3139. The original code requires 'package require Itcl' to run Itcl subparser from Tcl parser. However, `itcl::` can be used in a script having no 'package require Itcl' statement. Suggested by @bigfaceworm. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
itcl-no-package-notification
branch
from
c452753
to
1c3778f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3136.
Close #3139.
The original code requires 'package require Itcl' to run Itcl
subparser from Tcl parser. However,
itcl::can be used ina script having no 'package require Itcl' statement.
Suggested by @bigfaceworm.
Signed-off-by: Masatake YAMATO yamato@redhat.com