Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerShell: Keep the KEYWORD type and add a field for the keyword to tokenInfo #3479

Closed
kumarstack55 opened this issue Sep 10, 2022 · 0 comments · Fixed by #3480
Closed

PowerShell: Keep the KEYWORD type and add a field for the keyword to tokenInfo #3479

kumarstack55 opened this issue Sep 10, 2022 · 0 comments · Fixed by #3480

Comments

@kumarstack55
Copy link
Contributor

Goal of this Issue

Based on the discussion in #3476 , make the following changes already made.

  • Do not extend the token type.
  • Add field to tokenInfo.

Current Implementation

Reference

#3476 (comment)

If you are interested in improving the PowerShell parser, I have more comments.

...

using keyword API
You extended the types of token: KEYWORD_FUNCTION, and KEYWORD_CLASS.
However, keeping the type KEYWORD but adding keyword field to tokenInfo.
kumarstack55 added a commit to kumarstack55/ctags that referenced this issue Sep 10, 2022
@kumarstack55
PowerShell: keep the KEYWORD type
bb9b39b 
This commit reverts the keyword type that was removed in a previous PR
and adds the attribute keywordType to tokenInfo.

Close universal-ctags#3479
kumarstack55 added a commit to kumarstack55/ctags that referenced this issue Sep 10, 2022
@kumarstack55
PowerShell: keep the KEYWORD type
8edd3f4 
This commit reverts the keyword type that was removed in a previous PR
and adds the attribute keywordType to tokenInfo.

Close universal-ctags#3479
@kumarstack55 kumarstack55 mentioned this issue Sep 10, 2022
Merged
kumarstack55 added a commit to kumarstack55/ctags that referenced this issue Sep 11, 2022
@kumarstack55
PowerShell: use keyword api
11791e7 
This commit reverts the keyword type that was removed in a previous PR
and use keyword api.

Close universal-ctags#3479
kumarstack55 added a commit to kumarstack55/ctags that referenced this issue Sep 13, 2022
@kumarstack55
PowerShell: use keyword api
61f733e 
This commit reverts the keyword type that was removed in a previous PR
and use keyword api.

Close universal-ctags#3479
kumarstack55 added a commit to kumarstack55/ctags that referenced this issue Sep 13, 2022
@kumarstack55
PowerShell: use keyword api
143746b 
This commit reverts the keyword type that was removed in a previous PR
and use keyword api.

Close universal-ctags#3479
kumarstack55 added a commit to kumarstack55/ctags that referenced this issue Sep 20, 2022
@kumarstack55
PowerShell: use keyword api
108bfb5 
This commit reverts the keyword type that was removed in a previous PR
and use keyword api.

Close universal-ctags#3479
kumarstack55 added a commit to kumarstack55/ctags that referenced this issue Sep 23, 2022
@kumarstack55
PowerShell: introduce filer kind
52633a5 
Originally, this commit was going to use the keyword api, which is an
internal API provided by ctags. As a result of discussion on the
modification, it was changed so that function and filter are implemented
as different kinds.

Close universal-ctags#3479
kumarstack55 added a commit to kumarstack55/ctags that referenced this issue Sep 23, 2022
@kumarstack55
PowerShell: introduce filter kind
2851614 
Originally, this commit was going to use the keyword api, which is an
internal API provided by ctags. As a result of discussion on the
modification, it was changed so that function and filter are implemented
as different kinds.

Close universal-ctags#3479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PowerShell: introduce filter kind kumarstack55/ctags
1 participant
@kumarstack55