-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerShell: add tag generation from class #3476
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3476 +/- ##
=======================================
Coverage 83.33% 83.34%
=======================================
Files 219 219
Lines 52761 52789 +28
=======================================
+ Hits 43967 43995 +28
Misses 8794 8794
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I'm proud of u-ctags receiving a contribution from a person like you. I gave some comments. Feel free to do If you are interested in improving the PowerShell parser, I have more comments.
|
This improvement would be better. This is because I cannot think of a good way to do it right now, because I do not know how it should work with multiple inheritance and interface implementations, and how it should be implemented. |
Thank you for your review. My current PR is as follows:
Is the proposed implementation of @masatake as follows. :
@masatake : Is this understanding correct? |
Your understanding is correct. However, my proposal about keyword may make this pull request too bigger. So about keyword, I propose the following change in this pull request for keeping this pull request small and simple.
Let's forget |
Thank you for your comments. I have finished making changes to the code. If everything is ok, I will squash the commits.
|
Fine. Please squash the commits into the two. |
d45a7a4
to
c594496
Compare
I squashed it. |
Thank you! |
This pull request adds functionality to the existing parser.
Previously, the PowerShell parser generated tags from functions and variables.
By merging this pull request, it will be able to generate tags from classes in addition to those.
Please note that I do not have a lot of experience contributing to the open source community. Also, this is my first time attempting to contribute to u-ctags.
Please let me know if there are any details I should address.