Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: HTML comment starter in JavaScript area #3597

Closed
masatake opened this issue Dec 17, 2022 · 0 comments · Fixed by #3598
Closed

HTML: HTML comment starter in JavaScript area #3597

masatake opened this issue Dec 17, 2022 · 0 comments · Fixed by #3598

Comments

@masatake
Copy link
Member

input.html:

<h1>Foo</h1>
<script>
  // <!--
  var x
</script>

x is not extracted with the command line:

$ ctags --extras=+g input.html

This issue is a variable of issue #3581.

<h1>Foo</h1>
<script>
  // <!--
  var x
</script>

Originally posted by @masatake in #3581 (comment)
@masatake masatake mentioned this issue Dec 17, 2022
Closed
masatake added a commit to masatake/ctags that referenced this issue Dec 17, 2022
@masatake
HTML: introduce a specialized tokenizer for script areas
ddf6766 
The original code used a html-aware tokenizer for reading
tokens in <script>...</script> areas.

As reported in universal-ctags#3581 and universal-ctags#3597, this original code could
not recognize <script>...</script> areas in some cases.

This change introduces a tokenizer specialized to script
areas in addition to the original html-aware tokenizer.

Close universal-ctags#3581.
Close universal-ctags#3597.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake mentioned this issue Dec 17, 2022
Merged
masatake added a commit to masatake/ctags that referenced this issue Dec 17, 2022
@masatake
HTML: introduce a specialized tokenizer for script areas
baef2cd 
The original code used a html-aware tokenizer for reading
tokens in <script>...</script> areas.

As reported in universal-ctags#3581 and universal-ctags#3597, this original code could
not recognize <script>...</script> areas in some cases.

This change introduces a tokenizer specialized to script
areas in addition to the original html-aware tokenizer.

Close universal-ctags#3581.
Close universal-ctags#3597.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake added a commit that referenced this issue Dec 18, 2022
@masatake
Merge pull request #3598 from masatake/html--html-string-in-js-in-html
b2588fe 
HTML: introduce a specialized tokenizer for script areas

Close #3581.
Close #3597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HTML: introduce a specialized tokenizer for script areas masatake/ctags
1 participant
@masatake