HTML: introduce a specialized tokenizer for script areas #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 82.82% // Head: 82.82% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3598 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 223 223
Lines 54190 54190
=======================================
Hits 44884 44884
Misses 9306 9306 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The original code used a html-aware tokenizer for reading tokens in <script>...</script> areas. As reported in universal-ctags#3581 and universal-ctags#3597, this original code could not recognize <script>...</script> areas in some cases. This change introduces a tokenizer specialized to script areas in addition to the original html-aware tokenizer. Close universal-ctags#3581. Close universal-ctags#3597. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
html--html-string-in-js-in-html
branch
from
ddf6766
to
baef2cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code used a html-aware tokenizer for reading tokens in <script>...</script> areas.
As reported in #3581 and #3597, this original code could not recognize <script>...</script> areas in some cases.
This change introduces a tokenizer specialized to script areas in addition to the original html-aware tokenizer.
Close #3581.
Close #3597.
Signed-off-by: Masatake YAMATO yamato@redhat.com