Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemVerilog,refactor: call skipWhite() at the end of skipPastMatch() #2718

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

hirooih
Copy link
Contributor

@hirooih hirooih commented Nov 21, 2020

This fix improves readability and prevents bugs showed in #2703.

I am working on similar other issues.

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #2718 (96eaa20) into master (5a13631) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2718   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files         185      185           
  Lines       39466    39462    -4     
=======================================
- Hits        34333    34330    -3     
+ Misses       5133     5132    -1     
Impacted Files Coverage Δ
parsers/verilog.c 98.74% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a13631...96eaa20. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 87.083% when pulling 96eaa20 on hirooih:sv-createPastMatch into 4a9f00a on universal-ctags:master.

@masatake
Copy link
Member

LGTM.

@hirooih hirooih merged commit 1b2f82f into universal-ctags:master Nov 21, 2020
@masatake
Copy link
Member

@hirooih, if you need my review, please request reviewing explicitly via GitHub's web UI.
If changes are enough small or obvious, you don't need my review.

@hirooih
Copy link
Contributor Author

hirooih commented Nov 21, 2020

@hirooih, if you need my review, please request reviewing explicitly via GitHub's web UI.
If changes are enough small or obvious, you don't need my review.

I got you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants