-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI: add several features #3258
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3258 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 208 208
Lines 49507 49510 +3
=======================================
+ Hits 42230 42233 +3
Misses 7277 7277 ☔ View full report in Codecov by Sentry. |
Thank you.
|
It is non-informative and rarely used.
69b482d
to
9470b79
Compare
@masatake , renamed |
I'm reading https://spec.openapis.org/oas/latest.html slowly.
(to be continued...) |
This change is derrived from universal-ctags#3258. The original commit is so large. @masatake splited the commit smaller per-topic ones. @masatake wrote this commit log.
The original code tried matching even after making a tag for a token. This change is derrived from universal-ctags#3258. The original commit is so large. @masatake splited the commit smaller per-topic ones. @masatake wrote this commit log.
This change is derrived from universal-ctags#3258. The original commit is so large. @masatake splited the commit smaller per-topic ones. @masatake wrote this commit log.
This change is derrived from universal-ctags#3258. The original commit is so large. @masatake splited the commit smaller per-topic ones. @masatake wrote this commit log.
This change is derrived from universal-ctags#3258. The original commit is so large. @masatake splited the commit smaller per-topic ones. @masatake wrote this commit log. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake hi! What should we do with this PR? Do you expect me to fix the conflict, or you want to e.g. split it into parts and merge the parts by yourself or...? |
Sorry for making you wait. But could you wait for a while? I would like to finish the 'Basic' parser related task first. |
Yeah, no problem! Thx |
I would like to do merge some of the parts (and kinds). I will make a pull request for merging. I would like you to review the pull request. |
@masatake OK, seems fair. I'll try to split it following the necessary patch "granulation". |
@masatake friendly ping. Should I update this PR and show you for code review, or do you want to do it by yourself? |
@@ -53,3 +55,65 @@ components: | |||
schema: | |||
type: object | |||
properties: {} | |||
examples: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
X I'm talking about these.
I'm sorry to be late. I'm thinking about how to make the Yaml parser more extensible. (1) split the commit into smaller commits; each commit deals one kind, and If you want to have a kind X in your parser strongly, please put the commit for the kind in front of the commits of the pull request. I stopped my review when thinking about the "example" kind (See X). If the pull request is separated into commits per kind, I can merge ones obviously useful. |
OK, I'll try it the next week. |
No description provided.