Yaml,OpenAPI: make OpenAPI parser's stack related code reusable #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3295 +/- ##
==========================================
- Coverage 85.31% 85.28% -0.04%
==========================================
Files 210 211 +1
Lines 49784 49866 +82
==========================================
+ Hits 42475 42529 +54
- Misses 7309 7337 +28
Continue to review full report at Codecov.
|
|
I will rebase the changes of #3258 on this pull request. |
The technique used in the OpenAPI may be helpful to implement another YAML subparser. So, I moved the code implementing the technique to the YAML parser experimentally in this change. The original code uses an array of keywords for pointing out interesting tokens. This change uses a string for the same purpose. The routines in this change convert the string to an array of keywords. Till a real specification and its implementation becomes available, we call the format of the string Ypath. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
segoon
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The technique used in OpenAPI may be helpful to implement another YAML subparser.
So, I moved the code implementing the technique to the YAML parser experimentally in this change.
The original code uses an array of keywords for pointing out interesting tokens.
This change uses a string for the same purpose. The routines in this change convert the string to an array of keywords.
Till a real specification and its implementation becomes available, we call the format of the string Ypath.