Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML: new PEG based parser #3509

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

masatake
Copy link
Member

@masatake masatake commented Oct 16, 2022

The peg file is imported from

Copyright (c) Tom Preston-Werner
https://github.com/toml-lang/toml/blob/main/toml.abnf

peg/toml.peg Outdated Show resolved Hide resolved
@masatake masatake force-pushed the toml branch 4 times, most recently from f8298d7 to 479fcda Compare July 29, 2024 05:24
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.49%. Comparing base (a9e213c) to head (aed1e7f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3509      +/-   ##
==========================================
+ Coverage   85.45%   85.49%   +0.03%     
==========================================
  Files         235      236       +1     
  Lines       56848    56970     +122     
==========================================
+ Hits        48582    48705     +123     
+ Misses       8266     8265       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masatake masatake force-pushed the toml branch 2 times, most recently from d3bd6b0 to da8e9f1 Compare July 30, 2024 07:03
@masatake masatake marked this pull request as ready for review July 30, 2024 08:50
@masatake
Copy link
Member Author

It seems that a bug in pegof.

@dolik-rce
Copy link
Contributor

First problem I found is that pegof doesn't currently support unicode escapes in strings, e.g. underscore <- '\u005F'. It should be easy to implement.

@masatake masatake merged commit fa2a82d into universal-ctags:master Aug 8, 2024
69 checks passed
@masatake
Copy link
Member Author

masatake commented Aug 8, 2024

@dolik-rce Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants