iniconf: Allow dot and dash for ini keys #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iniconf parser can be used as a poor man's TOML parser which can contain '.' and '-' inside keys. Also, since there's no official ini specification, I can imagine some ini dialects allow this too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4052 +/- ##
=======================================
Coverage 85.47% 85.47%
=======================================
Files 236 236
Lines 56990 56990
=======================================
Hits 48715 48715
Misses 8275 8275 ☔ View full report in Codecov by Sentry. |
masatake
approved these changes
Aug 16, 2024
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iniconf parser can be used as a poor man's TOML parser which can contain '.' and '-' inside keys. Also, since there's no official ini specification, I can imagine some ini dialects allow this too.
I'm now aware of #3509 as mentioned in geany/geany#3934 but right now we don't use PEG parsers in Geany and we'd have to evaluate its performance so we'll probably stick with this parser for TOML for now.