Verilog validator #3791
Merged
Verilog validator #3791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix issues reported by [svlint](https://github.com/dalance/svlint) - Intended errors still remain Signed-off-by: Hiroo HAYASHI <24754036+hirooih@users.noreply.github.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3791 +/- ##
=======================================
Coverage 83.04% 83.04%
=======================================
Files 227 227
Lines 55201 55203 +2
=======================================
+ Hits 45841 45843 +2
Misses 9360 9360 ☔ View full report in Codecov by Sentry. |
masatake
reviewed
Aug 9, 2023
misc/validators/validator-svlint
Outdated
| # validator-svlint - validating Verilog/SystemVerilog input files with svlint | ||
| # https://github.com/dalance/svlint | ||
| # | ||
| # Copyright (c) 2023 Masatake YAMATO |
There was a problem hiding this comment.
I think your name should be here.
masatake
approved these changes
Aug 9, 2023
- Use NONE for intensional fails. - Use KNOWN-INVALIDATION for fails by svlint. Signed-off-by: Hiroo HAYASHI <24754036+hirooih@users.noreply.github.com>
hirooih
force-pushed
the
verilog-validator
branch
from
433c116
to
80ed7f3
Compare
|
@masatake san, Thank you for your review.
I also thought about this if I should fix this. I fixed it and merged this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@masatake san,
From #3787
Please review the validator functionality to ensure that it is being used as you intend.