Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(checkbox): Add lightweight styling to Checkbox #1048

Merged
merged 3 commits into from
Sep 28, 2023
Merged

feat(checkbox): Add lightweight styling to Checkbox #1048

merged 3 commits into from
Sep 28, 2023

Conversation

nguyeenvy
Copy link
Contributor

GitHub Issue: https://github.com/unoplatform/uno.themes-private/issues/13

PR Type

What kind of change does this PR introduce?

  • Feature

Description

PR Checklist

  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

Other information

Internal Issue (If applicable):

@nguyeenvy nguyeenvy requested a review from Xiaoy312 July 10, 2023 20:15
@nguyeenvy nguyeenvy self-assigned this Jul 10, 2023
@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jul 11, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-CheckBox branch from 4668b99 to 6b68a5f Compare July 12, 2023 16:36
@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

3 similar comments
@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy mentioned this pull request Jul 19, 2023
Closed
16 tasks
@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-CheckBox branch from 3fc1611 to fabdb7f Compare July 24, 2023 18:11
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy force-pushed the dev/vyng/Lightweight-Styling-CheckBox branch from fabdb7f to 3defaaa Compare July 24, 2023 18:21
@github-actions
Copy link

github-actions bot commented Jul 24, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@nguyeenvy nguyeenvy changed the title feat: Add lightweight styling to Checkbox feat(checkbox): Add lightweight styling to Checkbox Jul 24, 2023
@carlh98 carlh98 requested a review from kazo0 July 26, 2023 18:28
@agneszitte agneszitte marked this pull request as draft August 11, 2023 16:11
@nguyeenvy nguyeenvy marked this pull request as ready for review August 14, 2023 16:26
@nguyeenvy nguyeenvy marked this pull request as draft August 14, 2023 18:35
@kazo0 kazo0 marked this pull request as ready for review September 18, 2023 16:00
@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@kazo0 kazo0 mentioned this pull request Sep 18, 2023
Merged
6 tasks
@silviuo silviuo self-assigned this Sep 26, 2023
@silviuo silviuo force-pushed the dev/vyng/Lightweight-Styling-CheckBox branch from 555a4ff to 4bcf3ad Compare September 26, 2023 18:27
@silviuo
Copy link
Contributor

silviuo commented Sep 26, 2023

Rebased off latest main and pushed commit with resolved comments
@kazo0

@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@silviuo silviuo force-pushed the dev/vyng/Lightweight-Styling-CheckBox branch from 4bcf3ad to 1fb6bd6 Compare September 27, 2023 20:55
@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-rock-0cfebe70f-1048.eastus2.azurestaticapps.net

@kazo0 kazo0 merged commit fcb79c3 into master Sep 28, 2023
11 checks passed
@kazo0 kazo0 deleted the dev/vyng/Lightweight-Styling-CheckBox branch September 28, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@silviuo silviuo silviuo left review comments

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

@agneszitte agneszitte Awaiting requested review from agneszitte

Assignees

@silviuo silviuo

@nguyeenvy nguyeenvy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nguyeenvy @silviuo @kazo0 @agneszitte