Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lightweight Styling] Extract non-Brush values into lightweight resources #1067

Closed
15 of 16 tasks
kazo0 opened this issue Jul 19, 2023 · 2 comments
Closed
15 of 16 tasks

Comments

@kazo0
Copy link
Collaborator

kazo0 commented Jul 19, 2023

Following the example from the Button styles here, we should be extracting hardcoded values for things such as Margin, Padding, CornerRadius, etc. and placing them into lightweight styleable resources.

Taking the above Button style as an example, the only remaining step would be to move those resource definitions inside of the ThemeDictionaries and duplicate them across all dictionaries in the ThemeDictionaries

  • Button
  • CheckBox
  • TextBox
  • PasswordBox
  • ToggleButton
  • RadioButton
  • Slider
  • ProgressRing
  • ProgressBar
  • ComboBox
  • DatePicker
  • FloatingActionButton
  • TextBlock Style
  • PipsPager
  • HyperlinkButton Style
  • NavigationView
@pictos
Copy link
Contributor

pictos commented Jul 19, 2023

Can I work on the Button control?

@nguyeenvy
Copy link
Contributor

nguyeenvy commented Jul 19, 2023

PasswordBox: #1051
CheckBox: #1048

GitHub
GitHub Issue: unoplatform/uno.themes-private#18 PR Type What kind of change does this PR introduce?

Feature

Description

PR Checklist

Tested UWP
Tested iOS
Tested Android
Tested WASM
Tested ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants