Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ComboBox): lightweight styling for combobox #1103

Merged
merged 1 commit into from
Jul 27, 2023
Merged

refactor(ComboBox): lightweight styling for combobox #1103

merged 1 commit into from
Jul 27, 2023

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Jul 26, 2023 •
edited
Loading

GitHub Issue: #1005 #1067

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Description

  • Moved and refactored some resource keys into the ResourceDictionary for ComboBox.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

@rajamatt rajamatt self-assigned this Jul 26, 2023
@kazo0 kazo0 merged commit a6bb668 into master Jul 27, 2023
10 checks passed
@kazo0 kazo0 deleted the dev/mara/lightweight-styling-combobox branch July 27, 2023 16:35
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Jul 31, 2023 •
edited
Loading

backport legacy/2x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 31, 2023
@rajamatt @mergify
refactor(ComboBox): lightweight styling for combobox (#1103)
b458b33 
(cherry picked from commit a6bb668)
@mergify mergify bot mentioned this pull request Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

@agneszitte agneszitte Awaiting requested review from agneszitte

Assignees

@rajamatt rajamatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajamatt @agneszitte @kazo0