Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ToggleButton): lightweight styling for ToggleButton #1113

Merged
merged 1 commit into from
Aug 3, 2023
Merged

refactor(ToggleButton): lightweight styling for ToggleButton #1113

merged 1 commit into from
Aug 3, 2023

Conversation

carlh98
Copy link
Contributor

@carlh98 carlh98 commented Jul 26, 2023

GitHub Issue: #1067

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Description

Create ResourceDictionary.
Move non-brush resources into ResourceDictionary.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Internal Issue (If applicable):

@carlh98 carlh98 force-pushed the dev/cama/ToggleButtonStyling branch 3 times, most recently from 9b279d8 to 8e31ce5 Compare August 2, 2023 20:15
@carlh98 carlh98 force-pushed the dev/cama/ToggleButtonStyling branch from 8e31ce5 to 85c2604 Compare August 3, 2023 00:08
@kazo0 kazo0 merged commit c8d62d1 into master Aug 3, 2023
10 checks passed
@kazo0 kazo0 deleted the dev/cama/ToggleButtonStyling branch August 3, 2023 14:12
@kazo0
Copy link
Collaborator

kazo0 commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

https://github.com/Mergifyio backport legacy/2x

GitHub
Automate your pull requests. Mergify has 21 repositories available. Follow their code on GitHub.

@mergify
Copy link

mergify bot commented Aug 3, 2023 •
edited
Loading

backport legacy/2x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 3, 2023
@carlh98 @mergify
refactor(ToggleButton): lightweight styling for ToggleButton (#1113)
460022e 
(cherry picked from commit c8d62d1)
@mergify mergify bot mentioned this pull request Aug 3, 2023
Merged
kazo0 pushed a commit that referenced this pull request Aug 3, 2023
@mergify @carlh98
refactor(ToggleButton): lightweight styling for ToggleButton (backport …
eff3f55 
…#1113) (#1131)

Co-authored-by: Carl Mathieu <carlh.mathieu@gmail.com>
@carlh98 carlh98 mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazo0 kazo0 kazo0 approved these changes

@Xiaoy312 Xiaoy312 Awaiting requested review from Xiaoy312

@agneszitte agneszitte Awaiting requested review from agneszitte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlh98 @kazo0