Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(RadioButton): lightweight styling radiobutton #1069

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Jul 20, 2023

GitHub Issue: #991 #1067

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Description

  • Refactors non-brush resources for lightweight styling.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • Tested UWP
  • Tested iOS
  • Tested Android
  • Tested WASM
  • Tested MacOS
  • Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

@rajamatt rajamatt self-assigned this Jul 20, 2023
@rajamatt rajamatt force-pushed the dev/mara/lightweight-styling-radiobutton branch from 542d5bd to 98ccbe6 Compare July 25, 2023 15:58
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazo0 / @Xiaoy312
I think these values should not be hardcoded in the template of the Style also
image

@rajamatt rajamatt force-pushed the dev/mara/lightweight-styling-radiobutton branch from 424231a to f211aa1 Compare July 25, 2023 16:40
@rajamatt rajamatt mentioned this pull request Jul 25, 2023
6 tasks
fix: moved some keys back

refactor(RadioButton): lightweight styling radiobutton

refactor: checkellipse padding value

refactor(RadioButton): lightweight styling radiobutton

fix: renaming glyph resource

refactor(RadioButton): lightweight styling radiobutton
@rajamatt rajamatt force-pushed the dev/mara/lightweight-styling-radiobutton branch from 8a7968c to 94b186a Compare July 27, 2023 15:08
@kazo0 kazo0 merged commit da85fc6 into master Jul 27, 2023
10 checks passed
@kazo0 kazo0 deleted the dev/mara/lightweight-styling-radiobutton branch July 27, 2023 17:52
@agneszitte
Copy link
Contributor

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Jul 31, 2023

backport legacy/2x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 31, 2023
fix: moved some keys back

refactor(RadioButton): lightweight styling radiobutton

refactor: checkellipse padding value

refactor(RadioButton): lightweight styling radiobutton

fix: renaming glyph resource

refactor(RadioButton): lightweight styling radiobutton

(cherry picked from commit da85fc6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants