Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autolayout): collapsed children don't count in the measure #663

Merged
merged 1 commit into from
Jul 19, 2023
Merged

feat(autolayout): collapsed children don't count in the measure #663

merged 1 commit into from
Jul 19, 2023

Conversation

Robert-Louis
Copy link
Contributor

GitHub Issue (If applicable): #660

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Collapsed children are still measure

What is the new behavior?

Collapsed children are not measure

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Robert-Louis Robert-Louis self-assigned this Jul 19, 2023
@Robert-Louis Robert-Louis linked an issue Jul 19, 2023 that may be closed by this pull request
[AutoLayout] Collapsed elements in autolayout still takes space #660
Closed
17 tasks
@Robert-Louis Robert-Louis mentioned this pull request Jul 19, 2023
Closed
17 tasks
@github-actions
Copy link

github-actions bot commented Jul 19, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-663.eastus2.azurestaticapps.net

agneszitte
agneszitte reviewed Jul 19, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robert-Louis Can you add some tests for these changes, please
To make sure when an element is collapsed in AutoLayout it will not take any more space

@Xiaoy312 Xiaoy312 changed the title feat(autolayout): colapsed children don't count in the measure feat(autolayout): collapsed children don't count in the measure Jul 19, 2023
@Robert-Louis
Copy link
Contributor Author

@Robert-Louis Can you add some tests for these changes, please To make sure when an element is collapsed in AutoLayout it will not take any more space

I test it manualy. Unfortunatly I need to go now so I will not have the time add it today.

@Robert-Louis Robert-Louis force-pushed the dev/rlm/autolayout-visibility branch from 2fc2003 to c2fa7ab Compare July 19, 2023 15:59
@agneszitte
Copy link
Contributor

agneszitte commented Jul 19, 2023 •
edited
Loading

@kazo0 / @Xiaoy312
@Robert-Louis will be OOO for 10 days starting at noon today, so additional adjustments will need to be picked up by someone else if we want to have the changes merged soon

@github-actions
Copy link

github-actions bot commented Jul 19, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-663.eastus2.azurestaticapps.net

@agneszitte
Copy link
Contributor

@kazo0 / @Xiaoy312 @Robert-Louis will be OOO for 10 days starting at noon today, so additional adjustments will need to be picked up by someone else if we want to have the changes merged soon

@Robert-Louis you will be able to work on the tests when you are back, please
We will merge the current changes to at least have the fix during that time

@agneszitte agneszitte merged commit 4784666 into main Jul 19, 2023
@agneszitte agneszitte deleted the dev/rlm/autolayout-visibility branch July 19, 2023 18:53
@agneszitte
Copy link
Contributor

agneszitte commented Jul 21, 2023 •
edited by unfurl-links bot
Loading

https://github.com/Mergifyio backport release/stable/3.0

GitHub
Automate your pull requests. Mergify has 21 repositories available. Follow their code on GitHub.

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023 •
edited
Loading

backport release/stable/3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 21, 2023
@Robert-Louis @mergify
feat(autolayout): colapsed children don't count in the measure (#663)
131519d 
(cherry picked from commit 4784666)
@mergify mergify bot mentioned this pull request Jul 21, 2023
Merged
@agneszitte
Copy link
Contributor

agneszitte commented Jul 21, 2023 •
edited by unfurl-links bot
Loading

https://github.com/Mergifyio backport legacy/3x

GitHub
Automate your pull requests. Mergify has 21 repositories available. Follow their code on GitHub.

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023 •
edited
Loading

backport legacy/3x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 21, 2023
@Robert-Louis @mergify
feat(autolayout): colapsed children don't count in the measure (#663)
14dcfec 
(cherry picked from commit 4784666)
@mergify mergify bot mentioned this pull request Jul 21, 2023
Merged
agneszitte pushed a commit that referenced this pull request Jul 24, 2023
@mergify @Robert-Louis
feat(autolayout): colapsed children don't count in the measure (#663) (…
bd83c0a 
…#673)

(cherry picked from commit 4784666)

Co-authored-by: Robert-Louis <milinmt@gmail.com>
agneszitte pushed a commit that referenced this pull request Jul 24, 2023
@mergify @Robert-Louis
feat(autolayout): colapsed children don't count in the measure (#663) (…
1f3f16a 
…#674)

(cherry picked from commit 4784666)

Co-authored-by: Robert-Louis <milinmt@gmail.com>
@agneszitte
Copy link
Contributor

agneszitte commented Aug 8, 2023 •
edited
Loading

@kazo0 / @Xiaoy312 @Robert-Louis will be OOO for 10 days starting at noon today, so additional adjustments will need to be picked up by someone else if we want to have the changes merged soon

@Robert-Louis you will be able to work on the tests when you are back, please We will merge the current changes to at least have the fix during that time

Related PR for the Tests here : #691
(cc @jeromelaban / @kazo0 / @Xiaoy312)

@silviuo silviuo mentioned this pull request Sep 21, 2023
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban left review comments

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@carldebilly carldebilly Awaiting requested review from carldebilly

@dr1rrb dr1rrb Awaiting requested review from dr1rrb

@agneszitte agneszitte Awaiting requested review from agneszitte

@kazo0 kazo0 Awaiting requested review from kazo0

Assignees

@Robert-Louis Robert-Louis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AutoLayout] Collapsed elements in autolayout still takes space
5 participants
@Robert-Louis @agneszitte @Xiaoy312 @kazo0 @jeromelaban