Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autolayout): collapsed children don't count in the measure (backport #663) #673

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 21, 2023

This is an automatic backport of pull request #663 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@agneszitte
Copy link
Contributor

agneszitte commented Jul 21, 2023

@jeromelaban I think we should make sure it is properly fixing everything before backporting it to stable/3.0
(related backport #674)

@agneszitte agneszitte added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2023
@agneszitte agneszitte removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2023
@agneszitte
Copy link
Contributor

@jeromelaban I synced with @marc-antoine and the issue seems properly fixed with the related changes available in Uno.Toolkit 4.0.0-dev.55.
So I think we can backport the changes and @Robert-Louis will be able to add the proper tests for it when he is back.

@agneszitte agneszitte merged commit bd83c0a into release/stable/3.0 Jul 24, 2023
@agneszitte agneszitte deleted the mergify/bp/release/stable/3.0/pr-663 branch July 24, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants