Misc bugs around Xaml resources & code gen #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carldebilly
added
the
ready-to-merge
jeromelaban
approved these changes
Jun 21, 2019
7 tasks
davidjohnoliver
approved these changes
Jun 21, 2019
src/SamplesApp/UITests.Shared/Windows_UI_Xaml/Resources/XamlLocalResources.xaml
Outdated
Show resolved
Hide resolved
dr1rrb
approved these changes
Jun 21, 2019
When the resource wasn't found on non-DEBUG build, the non-resolving of a resource wasn't throwing an exception, causing potential null-ref exception without explanation.
when x:Name was used in App.xaml resources
Co-Authored-By: David Oliver <david.john.oliver@gmail.com>
carldebilly
force-pushed
the
dev/cdb/xaml-resources-key-and-name
branch
from
5196faf
to
fdf0e47
Compare
carldebilly
force-pushed
the
dev/cdb/xaml-resources-key-and-name
branch
from
fdf0e47
to
a216216
Compare
|
@all-contributors bot please add @carldebilly for code, tests, docs, review and maintenance |
|
I've put up a pull request to add @carldebilly! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix
Following issues:
What is the current behavior?
Using
x:Namein various XAML resources were producing compilation errors.What is the new behavior?
Right checks are added to code generators to prevent such compilation errors anymore.
PR Checklist
Please check if your PR fulfills the following requirements: