Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc bugs around Xaml resources & code gen #1112

Merged
merged 7 commits into from
Jun 21, 2019
Merged

Misc bugs around Xaml resources & code gen #1112

merged 7 commits into from
Jun 21, 2019

Commits on Jun 21, 2019

  1. Remove the silent exception on non-existent resource. 

    When the resource wasn't found on non-DEBUG build, the non-resolving of a resource wasn't throwing an exception, causing potential null-ref exception without explanation.
    @carldebilly
    carldebilly committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    42e8a02 View commit details
    Browse the repository at this point in the history

  2. Fix #706 - "The name 'Loading' does not exist in the current context" 

    when x:Name was used in App.xaml resources
    @carldebilly
    carldebilly committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    879bf2f View commit details
    Browse the repository at this point in the history

  3. Added support for "BasedOn" on styles in App.Xaml 

    Fix #854
    @carldebilly
    carldebilly committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    deede2b View commit details
    Browse the repository at this point in the history

  4. Fixed compilation error on x:Name on non-dependecy objects 

    Bug #846
    @carldebilly
    carldebilly committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    1a331d4 View commit details
    Browse the repository at this point in the history

  5. Update src/Uno.UI/FeatureConfiguration.cs 

    Co-Authored-By: David Oliver <david.john.oliver@gmail.com>
    @carldebilly @davidjohnoliver
    carldebilly and davidjohnoliver committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    ecb591b View commit details
    Browse the repository at this point in the history

  6. Moved xaml x:Name tests to right project

    @carldebilly
    carldebilly committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    1a6f905 View commit details
    Browse the repository at this point in the history

  7. Update release notes

    @carldebilly
    carldebilly committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    a216216 View commit details
    Browse the repository at this point in the history