Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce GLCanvasElement to allow externally adding sophisticated graphics #16621

Merged
merged 94 commits into from
Sep 5, 2024
Merged

feat: introduce GLCanvasElement to allow externally adding sophisticated graphics #16621

merged 94 commits into from
Sep 5, 2024

Conversation

ramezgerges
Copy link
Contributor

@ramezgerges ramezgerges commented May 7, 2024 •
edited by MartinZikmund
Loading

GitHub Issue (If applicable): closes #15166 closes #9405 closes #11034 closes https://github.com/unoplatform/private/issues/349

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation kind/documentation labels May 7, 2024
@ramezgerges ramezgerges mentioned this pull request May 7, 2024
Closed
6 tasks
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

jeromelaban
jeromelaban reviewed May 8, 2024
View reviewed changes
doc/articles/controls/SkiaCanvas.md Outdated Show resolved Hide resolved
doc/articles/controls/SkiaCanvas.md Outdated Show resolved Hide resolved
doc/articles/controls/SkiaCanvas.md Outdated Show resolved Hide resolved
doc/articles/controls/SkiaCanvas.md Outdated Show resolved Hide resolved
doc/articles/controls/SkiaCanvas.md Outdated Show resolved Hide resolved
doc/articles/controls/SkiaCanvas.md Outdated Show resolved Hide resolved
src/Uno.UI.Runtime.Skia/GLCanvasElement.cs Outdated Show resolved Hide resolved
src/Uno.UI.Runtime.Skia/GLCanvasElement.cs Outdated Show resolved Hide resolved
src/Uno.UI.Runtime.Skia/GLCanvasElement.cs Outdated Show resolved Hide resolved
src/Uno.UI.Runtime.Skia/GLCanvasElement.cs Outdated Show resolved Hide resolved
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@jeromelaban jeromelaban mentioned this pull request May 22, 2024
Open
1 task
@jeromelaban jeromelaban marked this pull request as draft June 26, 2024 18:28
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

2 similar comments
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@ramezgerges ramezgerges marked this pull request as ready for review August 8, 2024 17:38
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@ramezgerges ramezgerges changed the title feat: introduce SkiaVisual, SKCanvasElement and GLCanvasElement to allow externally adding sophisticated graphics feat: introduce SKCanvasElement and GLCanvasElement to allow externally adding sophisticated graphics Aug 9, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16621/index.html

@jeromelaban
Copy link
Member

The tests are failing, but it's likely fixed by a recent timeout bump.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16621/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16621/index.html

@ramezgerges ramezgerges changed the title feat: introduce SKCanvasElement and GLCanvasElement to allow externally adding sophisticated graphics feat: introduce GLCanvasElement to allow externally adding sophisticated graphics Sep 5, 2024
@jeromelaban jeromelaban merged commit 57cd135 into unoplatform:master Sep 5, 2024
102 checks passed
This was referenced Sep 6, 2024
Closed
Merged
@ramezgerges ramezgerges mentioned this pull request Oct 2, 2024
Open
6 tasks
@ramezgerges ramezgerges deleted the skiavisual_glcanvaselement branch October 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees

@ramezgerges ramezgerges

Labels
area/automation Categorizes an issue or PR as relevant to project automation area/build Categorizes an issue or PR as relevant to build infrastructure area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk area/skia ✏️ Categorizes an issue or PR as relevant to Skia kind/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenGL and/or Generic 3D View support Add support for SkiaVisual
5 participants
@ramezgerges @unodevops @jeromelaban @Youssef1313 @MartinZikmund