-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): GLCanvasElement #18216
base: master
Are you sure you want to change the base?
feat(android): GLCanvasElement #18216
Conversation
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18216/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18216/index.html |
if (newState.Equals(previousLayoutState)) | ||
{ | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a performance issue. Do you recall why you needed to remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's simply very incorrect. The fact that the previous and new layout states are the same doesn't mean that what will actually be drawn is the same. I looked quickly for a better condition but it didn't work out. I can look into optimizing this in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to create a repro that's completely independent of GLCanvasElement to illustrate the problem and opened a separate PR.
#18408
Building Uno.UI.Reference and Uno.UI.Skia in parallel was writing to the same mergedstyles.xaml, causing random crashes at runtime
c799f0f
to
e00a103
Compare
…nd remove NetPrevious-android from TargetFrameworks
c85bf40
to
c314461
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18216/index.html |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18216/index.html |
|
GitHub Issue (If applicable): #9405, follows from #16621
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):