-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publicKey field is not conform to the W3C specs #21
Comments
For reference, there is an open issue in the W3C specs to address the vagueness of the definition for item 1. |
mirceanis
added a commit
that referenced
this issue
Apr 14, 2021
BREAKING CHANGE: new did core spec uses different format for DID documents and resolution. BREAKING CHANGE: Now using ethers.js which means that providers and signers may have a different API BREAKING CHANGE: default export was removed closes #50 closes #59 closes #21 closes #49 closes #51 closes #52
mirceanis
added a commit
that referenced
this issue
Apr 14, 2021
BREAKING CHANGE: new did core spec uses different format for DID documents and resolution. BREAKING CHANGE: Now using ethers.js which means that providers and signers may have a different API BREAKING CHANGE: default export was removed closes #50 closes #59 closes #21 closes #49 closes #51 closes #52 closes #57 closes #58
mirceanis
added a commit
that referenced
this issue
Apr 15, 2021
* chore(deps): update deps * feat: adapt to latest did core spec BREAKING CHANGE: new did core spec uses different format for DID documents and resolution. BREAKING CHANGE: Now using ethers.js which means that providers and signers may have a different API BREAKING CHANGE: default export was removed closes #50 closes #59 closes #21 closes #49 closes #51 closes #52 closes #57 closes #58
uport-automation-bot
pushed a commit
that referenced
this issue
Apr 15, 2021
# [2.0.0](1.3.0...2.0.0) (2021-04-15) ### Features * adapt to latest did core spec and libs ([#61](#61)) ([839079d](839079d)), closes [#50](#50) [#59](#59) [#21](#21) [#49](#49) [#51](#51) [#52](#52) [#57](#57) [#58](#58) ### BREAKING CHANGES * new did core spec uses different format for DID documents and resolution. * Now using ethers.js which means that providers and signers may have a different API * default export was removed
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the public key section of W3C specs it says that:
The value property of a public key may be publicKeyPem, publicKeyJwk, publicKeyHex, publicKeyBase64 or similar, depending on the format and encoding of the public key.
-> It not explicitly said, but it is implied that the format for the value property should bepublicKey<ENCODING>
therefore the example in the README usingethereumAddress
as the value property is not validIn the W3C registry that summarizes the Linked Data key specifications currently known to the community, the identifier "Secp256k1VerificationKey2018" is not listed, but it is used in the README example.
The text was updated successfully, but these errors were encountered: