Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme errata #49

Closed
ilanolkies opened this issue Jun 24, 2020 · 2 comments · Fixed by #61
Closed

Readme errata #49

ilanolkies opened this issue Jun 24, 2020 · 2 comments · Fixed by #61
Labels
bug Something isn't working documentation There is something wrong with the docs

Comments

@ilanolkies
Copy link

Hi team,

The readme states 'An example of a DID document resolved using the Ethr-Did-Resolver:'

       type: 'Secp256k1SignatureAuthentication2018',

The DID v1.0 states in the specs registry:

"type": "EcdsaSecp256k1RecoveryMethod2020",

Ref: https://w3c.github.io/did-spec-registries/#ethereumaddress

Is the readme outdated? I'm not sure if this is an error
@mirceanis mirceanis added bug Something isn't working documentation There is something wrong with the docs labels Jun 26, 2020
@mirceanis
Copy link
Contributor

mirceanis commented Jan 26, 2021 •
edited

It's a bug, but not only in the readme, also in the ethr-did-resolver.

See also #52

mirceanis added a commit that referenced this issue Apr 14, 2021
@mirceanis
feat: adapt to latest did core spec
3411dc4 
BREAKING CHANGE: new did core spec uses different format for DID documents and resolution.
BREAKING CHANGE: Now using ethers.js which means that providers and signers may have a different API
BREAKING CHANGE: default export was removed

closes #50
closes #59
closes #21
closes #49
closes #51
closes #52
@mirceanis mirceanis mentioned this issue Apr 14, 2021
Merged
mirceanis added a commit that referenced this issue Apr 14, 2021
@mirceanis
feat: adapt to latest did core spec
3d090fc 
BREAKING CHANGE: new did core spec uses different format for DID documents and resolution.
BREAKING CHANGE: Now using ethers.js which means that providers and signers may have a different API
BREAKING CHANGE: default export was removed

closes #50
closes #59
closes #21
closes #49
closes #51
closes #52
closes #57
closes #58
mirceanis added a commit that referenced this issue Apr 15, 2021
@mirceanis
feat: adapt to latest did core spec and libs (#61)
839079d 
* chore(deps): update deps
* feat: adapt to latest did core spec

BREAKING CHANGE: new did core spec uses different format for DID documents and resolution.
BREAKING CHANGE: Now using ethers.js which means that providers and signers may have a different API
BREAKING CHANGE: default export was removed

closes #50
closes #59
closes #21
closes #49
closes #51
closes #52
closes #57
closes #58
uport-automation-bot pushed a commit that referenced this issue Apr 15, 2021
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
4834295 
# [2.0.0](1.3.0...2.0.0) (2021-04-15)

### Features

* adapt to latest did core spec and libs ([#61](#61)) ([839079d](839079d)), closes [#50](#50) [#59](#59) [#21](#21) [#49](#49) [#51](#51) [#52](#52) [#57](#57) [#58](#58)

### BREAKING CHANGES

* new did core spec uses different format for DID documents and resolution.
* Now using ethers.js which means that providers and signers may have a different API
* default export was removed
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation There is something wrong with the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adapt to latest did core spec and libs uport-project/ethr-did
3 participants
@mirceanis @ilanolkies @uport-automation-bot