Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix Wuhan crash #151

Merged
merged 1 commit into from
Dec 10, 2024
Merged

BUG: fix Wuhan crash #151

merged 1 commit into from
Dec 10, 2024

Conversation

martinfleis
Copy link
Contributor

Fixes Wuhan crashing on Apple Silicon. _shared_node had two unique values. Calling mode fixes that.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.8%. Comparing base (5fade1e) to head (fbac213).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #151     +/-   ##
=======================================
- Coverage   98.8%   98.8%   -0.0%     
=======================================
  Files          6       6             
  Lines       1001    1000      -1     
=======================================
- Hits         989     988      -1     
  Misses        12      12             
Files with missing lines Coverage Δ
neatnet/nodes.py 100.0% <100.0%> (ø)

Copy link
Collaborator

@jGaboardi jGaboardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! 🙇

@jGaboardi jGaboardi merged commit fd6e747 into main Dec 10, 2024
12 checks passed
@jGaboardi jGaboardi deleted the wuhan-fix branch December 10, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants